Add GDPR annotations #27217
Add GDPR annotations #27217
Conversation
| @@ -2737,6 +2737,13 @@ namespace ts.server.protocol { | |||
| payload: TypingsInstalledTelemetryEventPayload; | |||
| } | |||
|
|
|||
| /* __GDPR__ | |||
| "typingsinstalled" : { | |||
There was a problem hiding this comment.
Looks like there might also be a version property.
There was a problem hiding this comment.
Where? I thought the properties only came from the interface itself.
There was a problem hiding this comment.
Looks like the correct fix would be to reference TypeScriptCommonProperties.
There was a problem hiding this comment.
(For the other comment as well.)
There was a problem hiding this comment.
Unfortunately, this doesn't work right now. Filed Microsoft/vscode-gdpr-tooling#6 to track. I think I'll merge this anyway since we have existing metadata to fall back on.
|
I think it might be helpful to link to the comment tool repo in the commit message. |
|
I'll follow up with actions for |
Note that
projectIdis not included in the metadata. It should be, but marked as excluded, I believe. I need to ask @kieferrm whether vscode-gdpr-tooling needs to add support for this combination.