Skip to content

🤖 User test baselines have changed #27141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2018
Merged

🤖 User test baselines have changed #27141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/baselines/reference/user/async.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ node_modules/async/dist/async.js(31,29): error TS1003: Identifier expected.
node_modules/async/dist/async.js(31,30): error TS1003: Identifier expected.
node_modules/async/dist/async.js(257,56): error TS2339: Property 'Object' does not exist on type 'Window'.
node_modules/async/dist/async.js(298,7): error TS2454: Variable 'unmasked' is used before being assigned.
node_modules/async/dist/async.js(480,35): error TS2538: Type 'true' cannot be used as an index type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

node_modules/async/dist/async.js(480,59): error TS2538: Type 'true' cannot be used as an index type.
node_modules/async/dist/async.js(622,80): error TS2339: Property 'nodeType' does not exist on type 'NodeModule'.
node_modules/async/dist/async.js(748,84): error TS2339: Property 'nodeType' does not exist on type 'NodeModule'.
node_modules/async/dist/async.js(754,49): error TS2339: Property 'process' does not exist on type 'false | Global'.
Expand Down Expand Up @@ -523,8 +521,6 @@ node_modules/async/internal/filter.js(64,29): error TS2695: Left side of comma o
node_modules/async/internal/filter.js(66,18): error TS2695: Left side of comma operator is unused and has no side effects.
node_modules/async/internal/filter.js(72,19): error TS2695: Left side of comma operator is unused and has no side effects.
node_modules/async/internal/filter.js(73,27): error TS2695: Left side of comma operator is unused and has no side effects.
node_modules/async/internal/getIterator.js(8,35): error TS2538: Type 'true' cannot be used as an index type.
node_modules/async/internal/getIterator.js(8,59): error TS2538: Type 'true' cannot be used as an index type.
node_modules/async/internal/initialParams.js(9,21): error TS2695: Left side of comma operator is unused and has no side effects.
node_modules/async/internal/iterator.js(41,18): error TS2695: Left side of comma operator is unused and has no side effects.
node_modules/async/internal/iterator.js(51,10): error TS2695: Left side of comma operator is unused and has no side effects.
Expand Down
65 changes: 37 additions & 28 deletions tests/baselines/reference/user/chrome-devtools-frontend.log
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/baselines/reference/user/debug.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ node_modules/debug/dist/debug.js(8,21): error TS2304: Cannot find name 'define'.
node_modules/debug/dist/debug.js(8,46): error TS2304: Cannot find name 'define'.
node_modules/debug/dist/debug.js(9,5): error TS2304: Cannot find name 'define'.
node_modules/debug/dist/debug.js(33,33): error TS2554: Expected 1 arguments, but got 2.
node_modules/debug/dist/debug.js(34,27): error TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'true | NodeRequire' has no compatible call signatures.
node_modules/debug/dist/debug.js(34,27): error TS2554: Expected 1 arguments, but got 2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type changed from true | NodeRequire to false | NodeRequire. I think this must be the result of a change in the source code.

node_modules/debug/dist/debug.js(36,21): error TS2339: Property 'code' does not exist on type 'Error'.
node_modules/debug/dist/debug.js(89,38): error TS2339: Property 'length' does not exist on type 'string | number'.
Property 'length' does not exist on type 'number'.
Expand Down
17 changes: 0 additions & 17 deletions tests/baselines/reference/user/formik.log
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions tests/baselines/reference/user/graceful-fs.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,6 @@ node_modules/graceful-fs/graceful-fs.js(161,5): error TS2539: Cannot assign to '
node_modules/graceful-fs/graceful-fs.js(162,5): error TS2539: Cannot assign to 'WriteStream' because it is not a variable.
node_modules/graceful-fs/graceful-fs.js(252,3): error TS2554: Expected 0 arguments, but got 3.
node_modules/graceful-fs/graceful-fs.js(259,5): error TS2554: Expected 0 arguments, but got 3.
node_modules/graceful-fs/polyfills.js(7,24): error TS2339: Property 'env' does not exist on type 'typeof process'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the result of the inter-file merging fix.

node_modules/graceful-fs/polyfills.js(7,60): error TS2339: Property 'platform' does not exist on type 'typeof process'.
node_modules/graceful-fs/polyfills.js(32,15): error TS2339: Property 'version' does not exist on type 'typeof process'.
node_modules/graceful-fs/polyfills.js(73,23): error TS2339: Property 'nextTick' does not exist on type 'typeof process'.
node_modules/graceful-fs/polyfills.js(79,23): error TS2339: Property 'nextTick' does not exist on type 'typeof process'.
node_modules/graceful-fs/polyfills.js(229,62): error TS2339: Property 'nextTick' does not exist on type 'typeof process'.
node_modules/graceful-fs/polyfills.js(323,26): error TS2339: Property 'getuid' does not exist on type 'typeof process'.
node_modules/graceful-fs/polyfills.js(323,44): error TS2339: Property 'getuid' does not exist on type 'typeof process'.



Expand Down
6 changes: 3 additions & 3 deletions tests/baselines/reference/user/jimp.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Exit Code: 1
Standard output:
node_modules/jimp/jimp.d.ts(487,12): error TS7010: 'appendConstructorOption', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/jimp/jimp.d.ts(529,12): error TS7010: 'measureText', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/jimp/jimp.d.ts(530,12): error TS7010: 'measureTextHeight', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/jimp/jimp.d.ts(497,12): error TS7010: 'appendConstructorOption', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/jimp/jimp.d.ts(539,12): error TS7010: 'measureText', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/jimp/jimp.d.ts(540,12): error TS7010: 'measureTextHeight', which lacks return-type annotation, implicitly has an 'any' return type.



Expand Down
Loading