Improve use of SemanticMeaning in symbol display #26953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

1 commit merged into master from symbolDisplayMeaning

Sep 7, 2018

ghost commented Sep 7, 2018

Only set symbolKind to "function" if SemanticMeaning.Value is set.
Only display a type alias if SemanticMeaning.Type is set.
Handle this type correctly. (Previously was treated as a parameter.)
ExternalModuleReferences should have SemanticMeaning.All.

(Part of #13766)


          Improve use of SemanticMeaning in symbol display

24f6932

ghost requested a review from sheetalkamat

September 7, 2018 00:23

sheetalkamat approved these changes

View reviewed changes

ghost merged commit cbde861 into master

ghost deleted the symbolDisplayMeaning branch

September 7, 2018 19:23

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet