Skip to content

Improve 'isWriteAccess' for findAllReferences #26889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 6, 2018
Merged

Improve 'isWriteAccess' for findAllReferences #26889

1 commit merged into from
Sep 6, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2018

Previously we would consider any declaration a write access, even let x; which does not write a value into x. Now we will be more careful.

(Part of #13766)

@ghost ghost force-pushed the isWriteAccess branch from a5dba0b to 8f517ab Compare September 4, 2018 23:24
@ghost ghost force-pushed the isWriteAccess branch from 8f517ab to 9fad299 Compare September 4, 2018 23:25
@ghost ghost requested review from sheetalkamat and amcasey September 5, 2018 00:24
@ghost ghost merged commit 8c22770 into master Sep 6, 2018
@ghost ghost deleted the isWriteAccess branch September 6, 2018 17:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey Awaiting requested review from amcasey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sheetalkamat