Skip to content

add index signature for anonymous object literal type #26710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

add index signature for anonymous object literal type #26710

wants to merge 3 commits into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Aug 28, 2018 •
edited
Loading

Fixes #14951

  • accept baseline

@Kingwl Kingwl force-pushed the anonymous_object_literal_type_index_signature branch from 37f6a24 to c516d57 Compare August 28, 2018 12:50
@RyanCavanaugh
Copy link
Member

@Kingwl please see implementation comments in #14951 (comment) - we'd rather have a solution based on the entire property access expression instead of creating an index signature as originally suggested. Thanks!

RyanCavanaugh
RyanCavanaugh requested changes Aug 28, 2018
View reviewed changes
Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comment)

@RyanCavanaugh
Copy link
Member

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 29, 2018 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 2d01edd. You can monitor the build here. It should now contribute to this PR's status checks.

@Kingwl
Copy link
Contributor Author

Kingwl commented Sep 13, 2018

⬆️

@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.2 milestone Sep 17, 2018
@RyanCavanaugh RyanCavanaugh self-assigned this Jan 25, 2019
@RyanCavanaugh
Copy link
Member

@typescript-bot test this again

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 25, 2019 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 2d01edd. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh
Copy link
Member

@typescript-bot test this one more time?

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 23, 2019 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 2d01edd. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh
Copy link
Member

@Kingwl this has a hairy conflict with master, can you investigate?

@RyanCavanaugh RyanCavanaugh removed their assignment Apr 25, 2019
@weswigham
Copy link
Member

I think the logic in this PR probably deserves less syntax-based checks and should probably be updated logic in getPropertyTypeForIndexType for FreshLiteral object-flagged types.

@RyanCavanaugh
Copy link
Member

Closing due to inactivity. Feel free to open a new PR later!

@okmttdhr okmttdhr mentioned this pull request Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Community (deprecated)
Development

Successfully merging this pull request may close these issues.

type has no index signature
5 participants
@Kingwl @RyanCavanaugh @typescript-bot @weswigham @DanielRosenwasser