Skip to content

In pickLongestCandidateSignature, instantiate using inferred type arguments #26646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Aug 27, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2018

Fixes #26639 and #26132

@ghost ghost mentioned this pull request Aug 23, 2018
@ghost ghost requested review from sandersn and sheetalkamat August 23, 2018 22:59
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine barring one question: This code runs as part of error reporting, right? Why then do only fourslash tests change? It seems like we should have some test coverage of our errors for overloads.

@ghost
Copy link
Author

ghost commented Aug 27, 2018

See #26426 (comment) -- for some reason the code only runs in services.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant