Skip to content

Emit lib reference directives in declaration output #26564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

Emit lib reference directives in declaration output #26564

merged 1 commit into from
Aug 21, 2018

Conversation

rbuckton
Copy link
Contributor

This updates our declaration emitter to also emit /// <reference lib="..." /> directives to the resulting declaration file.

Fixes #26497

weswigham
weswigham requested changes Aug 20, 2018
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a test with outFile, module: amd and declaration: true

@rbuckton rbuckton merged commit 42c9208 into master Aug 21, 2018
@rbuckton rbuckton deleted the fix26497 branch August 21, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbuckton @weswigham