Simplify call resolution logic #26481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sheetalkamat No, this has no effect on #26426. |
|
@typescript-bot test this por favor |
|
Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at bfe7f02. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Running RWC locally to get diffs |
|
@weswigham running the tests locally doesn't yield any diffs. Ideas? |
|
@RyanCavanaugh the test fails if rwc on master isn't clean. The bot should open a PR on our RWC repo with the diff if there is one. |
sandersn
approved these changes
Aug 17, 2018
weswigham
reviewed
Aug 17, 2018
| return getLiteralType(name.text); | ||
| case SyntaxKind.ComputedPropertyName: | ||
| const nameType = checkComputedPropertyName(name); | ||
| return isTypeAssignableToKind(nameType, TypeFlags.ESSymbolLike) ? nameType : stringType; |
There was a problem hiding this comment.
This should probably be handling late bound names.
eg,
const methodName = "method";
class Foo {
@dec [methodName] {}
}Unless I'm mistaken and for some reason checking with the more specific name is undesirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies our call resolution logic. Over time the
resolveCallfunction had gotten quite unwieldy, particularly in thegetEffectiveArgumentXXXfunctions that abstracted over access to the argument list. We now always construct an argument list and useSyntheticExpressionnodes to represent synthetic arguments. Also, for reasons not entirely clear, we would include context sensitive arguments one at a time, with intervening full rounds of inference and applicability checking, instead of just including all of them in one go. The code is now easier to follow and about 250 lines shorter.