Skip to content

🤖 User test baselines have changed #26419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2018
Merged

🤖 User test baselines have changed #26419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/baselines/reference/user/follow-redirects.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
Exit Code: 1
Standard output:
node_modules/follow-redirects/index.js(78,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(79,10): error TS2339: Property 'abort' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(192,12): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(226,35): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
node_modules/follow-redirects/index.js(80,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(81,10): error TS2339: Property 'abort' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(195,12): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(229,35): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
node_modules/follow-redirects/index.js(239,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(242,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.



Expand Down
4 changes: 1 addition & 3 deletions tests/baselines/reference/user/jimp.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
Exit Code: 1
Standard output:
node_modules/jimp/jimp.d.ts(268,16): error TS7010: 'appendConstructorOption', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/jimp/jimp.d.ts(270,19): error TS2304: Cannot find name 'function'.
node_modules/jimp/jimp.d.ts(271,18): error TS2304: Cannot find name 'function'.
node_modules/jimp/jimp.d.ts(499,16): error TS7010: 'appendConstructorOption', which lacks return-type annotation, implicitly has an 'any' return type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They just rewrote their d.ts entirely, so this improvement is expected.




Expand Down