Use updateGraphIfDirty to do quick check if project update is needed #26137
Conversation
With this updateGraph is used only in locations we are certain project is dirty
| @@ -337,7 +337,8 @@ namespace ts.server { | |||
| return `Project: ${project ? project.getProjectName() : ""} WatchType: ${watchType}`; | |||
| } | |||
|
|
|||
| function updateProjectIfDirty(project: Project) { | |||
| /*@internal*/ | |||
| export function updateProjectIfDirty(project: Project) { | |||
| return project.dirty && project.updateGraph(); | |||
There was a problem hiding this comment.
Why not put this check directly in updateGraph? Are there cases where we want to force an update regardless?
There was a problem hiding this comment.
There are cases we already know that project is dirty..
Updategraph is also overridden to do extra things depending on project type so update graph is not place where you want to do this check
There was a problem hiding this comment.
As a caller, how do I know whether I should call updateProjectIfDirty or updateGraph?
|
If you know project is dirty for sure you use updateGraph otherwise updateIfDirty. (eg. when you are updating the root file names because new files were added to the project, changing compiler options, creating project first time is when you use updateGraph, rest all is updateIfDirty) |
With this updateGraph is used only in locations we are certain project is dirty
This reduces the number of times updateGraph is called when there is no change