Adds check for abstract methods to generator grammar #25711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2018 23:57
Before, the compiler would fail on abstract generator methods, since it would confirm the abstract method had no body; but when checking the generator grammar, it would see the lack of a `node.body` and fail it as an overloaded generator. Adding a check for the Abstract flag means the compiler accurately recognizes the abstract generator not as an overload, but as an abstract method.
|
|
aleph-naught2tog
changed the title
added 3 commits
July 17, 2018 00:22
The first fix for allowing abstract generators also meant that abstract overloaded generators were allowed. This prevents any overloading of generators, abstract or not, while still allowing the declaration of abstract generator methods.
src/compiler/checker.ts
Outdated
| if (!node.body) { | ||
| return grammarErrorOnNode(node.asteriskToken!, Diagnostics.An_overload_signature_cannot_be_declared_as_a_generator); | ||
| if (!node.body && !hasModifier(node, ModifierFlags.Abstract)) { | ||
| return grammarErrorOnNode(node.asteriskToken!, Diagnostics.An_overload_signature_cannot_be_declared_as_a_generator); |
There was a problem hiding this comment.
Can you fix the indentation?
There was a problem hiding this comment.
@DanielRosenwasser done!
|
I do not think this is a change we want to make. see my comment in #25710 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25710