Add tsserver test for completions and avoid excess properties #25622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
amcasey
approved these changes
Jul 13, 2018
| } | ||
|
|
||
| function codeFixActionToCodeAction({ description, changes, commands }: CodeFixAction): CodeAction { | ||
| return { description, changes, commands }; |
There was a problem hiding this comment.
Currently protocol.ts CompletionEntryDetails contains a CodeAction[] and CodeAction has commands on it. I could make a CodeActionWithoutCommands interface if you think it's important that a completion never has commands (which it probably shouldn't since they're easy to trigger on accident).
There was a problem hiding this comment.
@amcasey Please open a new issue if you would like CodeActionWithoutCommands.
There was a problem hiding this comment.
Not very important. Thanks for following up though!
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amcasey Noticed that we were returning excess properties in the completions code actions. (#202)