Gracefully handle accessor declarations in ambient classes. #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure was due to a strange timeout we've seen once before with Travis. Shouldn't be an issue, likely will succeed if you happen to push any further changes. |
|
I forced an update, let's see how it do. |
| @@ -4948,7 +4948,7 @@ module ts { | |||
| } | |||
|
|
|||
| checkSourceElement(node.body); | |||
| if (node.type) { | |||
| if (node.type && !isAccessor(node.kind)) { | |||
There was a problem hiding this comment.
Don't you still need to do this for setters?
There was a problem hiding this comment.
Setters don't need to have their bodies checked - they don't return anything.
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Jul 29, 2014
Gracefully handle accessor declarations in ambient classes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139.