🤖 User test baselines have changed #25576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
force-pushed
the
user-update-20180603
branch
from
cbb08bb to
3a67ea8
Compare
mhegazy
reviewed
Jul 11, 2018
| node_modules/async/dist/async.js(2450,5): error TS2322: Type '{ [x: string]: any; _tasks: DLL; concurrency: any; payload: any; saturated: () => void; unsaturat...' is not assignable to type 'NodeModule'. | ||
| Property 'exports' is missing in type '{ [x: string]: any; _tasks: DLL; concurrency: any; payload: any; saturated: () => void; unsaturat...'. | ||
| node_modules/async/dist/async.js(2450,5): error TS2322: Type '{ [x: string]: any; _tasks: DLL; concurrency: any; payload: any; saturated: () => void; unsaturated: () => void; buffer: number; empty: () => void; drain: () => void; error: () => void; started: boolean; paused: boolean; ... 10 more ...; resume: () => void; }' is not assignable to type 'NodeModule'. | ||
| Property 'exports' is missing in type '{ [x: string]: any; _tasks: DLL; concurrency: any; payload: any; saturated: () => void; unsaturated: () => void; buffer: number; empty: () => void; drain: () => void; error: () => void; started: boolean; paused: boolean; ... 10 more ...; resume: () => void; }'. |
There was a problem hiding this comment.
@weswigham maybe we should make the cutoff shorter for the error truncation.
mhegazy
reviewed
Jul 11, 2018
| node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(263,31): error TS2345: Argument of type 'ExtensionServerPanelView' is not assignable to parameter of type '{ [x: string]: any; viewId(): string; title(): string; isCloseable(): boolean; isTransient(): boo...'. | ||
| Property '_name' does not exist on type '{ [x: string]: any; viewId(): string; title(): string; isCloseable(): boolean; isTransient(): boo...'. | ||
| node_modules/chrome-devtools-frontend/front_end/extensions/ExtensionServer.js(263,31): error TS2345: Argument of type 'ExtensionServerPanelView' is not assignable to parameter of type '{ [x: string]: any; viewId(): string; title(): string; isCloseable(): boolean; isTransient(): boolean; toolbarItems(): Promise<({ [x: string]: any; item(): any & any; } & { [x: string]: any; item(): any & any; })[]>; widget(): Promise<...>; disposeView(): void; }'. | ||
| Property '_name' does not exist on type '{ [x: string]: any; viewId(): string; title(): string; isCloseable(): boolean; isTransient(): boolean; toolbarItems(): Promise<({ [x: string]: any; item(): any & any; } & { [x: string]: any; item(): any & any; })[]>; widget(): Promise<...>; disposeView(): void; }'. |
There was a problem hiding this comment.
man any & any looks ugly.. @sandersn do you know where that is coming from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @mhegazy