handle multiple prologue directives #25561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbuckton and @weswigham can you please review this change |
weswigham
approved these changes
Jul 10, 2018
rbuckton
suggested changes
Jul 10, 2018
| let statementIndex = 0; | ||
| // skip all prologue directives to insert at the correct position | ||
| for (; statementIndex < to.length; ++statementIndex) { | ||
| if (!isPrologueDirective(to[statementIndex])) { |
There was a problem hiding this comment.
prependStatements shouldn't care about prologue directives. This logic should be handled elsewhere at the call site instead.
There was a problem hiding this comment.
Just rename prependStatements - every single one of it's callsites needs to do this.
There was a problem hiding this comment.
That's probably fine. The general-purpose name of prependStatements means it could be used in any place where there's a statement list, including a Block or a CaseClause, which don't support prologue directives. Giving it a more specific name would remove that concern.
|
@rbuckton one more look? |
rbuckton
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24689