Skip to content

Use getEmitDeclarations instead of .declarations #25524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

Use getEmitDeclarations instead of .declarations #25524

merged 1 commit into from
Jul 10, 2018

Conversation

RyanCavanaugh
Copy link
Member

Fixes an issue @DanielRosenwasser noticed when declaration wasn't explicitly set in the tsconfig file

@sheetalkamat
Copy link
Member

Please add test for the scenario fixed.

@RyanCavanaugh RyanCavanaugh force-pushed the useGetEmitDeclarations branch from e6c833c to 1b1ffe9 Compare July 9, 2018 21:51
@RyanCavanaugh
Copy link
Member Author

@sheetalkamat 👍 done

@RyanCavanaugh RyanCavanaugh merged commit d7ce0ea into microsoft:master Jul 10, 2018
@RyanCavanaugh RyanCavanaugh deleted the useGetEmitDeclarations branch July 10, 2018 20:28
@RyanCavanaugh RyanCavanaugh mentioned this pull request Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanCavanaugh @sheetalkamat