Skip to content

getLeftmostExpression: handle AsExpression and NonNullExpression #25342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2018
Merged

getLeftmostExpression: handle AsExpression and NonNullExpression #25342

merged 3 commits into from
Jul 4, 2018

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Jun 30, 2018

Fixes: #25223

@DanielRosenwasser
Copy link
Member

Great! Can you add the tests from your original issue to our src/unittests folder? I'd say it should probably be in transform.ts, but maybe it should be in printer.ts depending on the answer to #25223 (comment)

@ajafff
Copy link
Contributor Author

ajafff commented Jul 2, 2018

I added a new file src/testRunner/unittests/factory.ts as I will probably add more tests for factory functions while I fix the remaining issues.
Note that I used createArrowFunction for testing to avoid conflicts with #25348

@ajafff ajafff mentioned this pull request Jul 3, 2018
Closed
@mhegazy mhegazy requested review from rbuckton and weswigham July 3, 2018 22:20
@mhegazy
Copy link
Contributor

mhegazy commented Jul 3, 2018

@rbuckton can you please review and merge

@DanielRosenwasser DanielRosenwasser merged commit e4145e3 into microsoft:master Jul 4, 2018
@DanielRosenwasser
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuckton rbuckton Awaiting requested review from rbuckton

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajafff @DanielRosenwasser @mhegazy