Skip to content

Simplify getRangeOfEnclosingComment #25168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Jun 29, 2018
Merged

Simplify getRangeOfEnclosingComment #25168

2 commits merged into from
Jun 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2018

  • Use find instead of manual loop.
  • No need to take onlyMultiLine and predicate as parameters; can just filter the result if needed.

@ghost ghost force-pushed the getRangeOfEnclosingComment branch 3 times, most recently from c71a3e3 to 2593348 Compare June 25, 2018 17:43
@ghost ghost requested a review from uniqueiniquity June 25, 2018 17:43
@ghost ghost force-pushed the getRangeOfEnclosingComment branch from 2593348 to 410c3d2 Compare June 26, 2018 20:24
uniqueiniquity
uniqueiniquity approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@uniqueiniquity uniqueiniquity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost ghost merged commit e7543d6 into master Jun 29, 2018
@ghost ghost deleted the getRangeOfEnclosingComment branch June 29, 2018 23:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uniqueiniquity