Support async tests in runtests-parallel #24868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbuckton: why not just publish the mocha types to GitHub and reference the repo in the package.json - that way they don't need to be in this PR, and don't need to be removed when they're upstreamed? |
rbuckton
force-pushed
the
parallelAsyncTests
branch
from
7212de1 to
ece8f26
Compare
|
@weswigham rather than that, do you want to just take a look at DefinitelyTyped/DefinitelyTyped#26396? |
|
@rbuckton Now that the mocha types are merged and published, is this OK to have its merge conflicts resolved and then merged? |
weswigham
approved these changes
Jun 15, 2018
|
Where the types needed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently discovered when adding some evaluation tests, our parallel test runner did not support async mocha tests (either using
done, or via async functions). This changes the parallel test runner to leverage more of Mocha to actually run the tests in each parallel worker to avoid future inconsistencies.NOTE: This PR includes a private copy of the mocha definitions until such time as DefinitelyTyped/DefinitelyTyped#26396 has been merged.