Always get latest tag of types-registry #24608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jun 1, 2018
| @@ -523,12 +523,12 @@ namespace ts.server.typingsInstaller { | |||
|
|
|||
| protected abstract installWorker(requestId: number, packageNames: string[], cwd: string, onRequestCompleted: RequestCompletedAction): void; | |||
| protected abstract sendResponse(response: SetTypings | InvalidateCachedTypings | BeginInstallTypes | EndInstallTypes): void; | |||
|
|
|||
| protected latestDistTag = "latest"; | |||
There was a problem hiding this comment.
Should probably be readonly, or leave as const and export
ghost
approved these changes
Jun 1, 2018
mhegazy
approved these changes
Jun 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bad version of the types registry were to get published, we'd like to be able to set the
latesttag to a previous version so that type acquisition isn't broken for everyone.However, currently, this will only help those who have not already updated to the new, bad version.
This PR aims to ensure users are always getting the version of
types-registrytagged aslatestso we can successful roll back all users, not just those who haven't updated yet.