Skip to content

Fix issue with formatting object literal csharp style #24262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2018

Conversation

armanio123
Copy link
Contributor

Fixes feedback: https://developercommunity.visualstudio.com/content/problem/253676/js-and-ts-indentation-issue.html.

Current formatting:

var clear =
    {
        outerKey:
            {
                innerKey: 1
            }
    };

Expected formatting:

var clear =
{
    outerKey:
    {
        innerKey: 1
    }
};

@armanio123 armanio123 requested review from billti, mhegazy and a user May 18, 2018 23:39
@mhegazy
Copy link
Contributor

mhegazy commented May 19, 2018

How this different from #22849, and why is the fix in #22849 not sufficient?

i see it working for me locally...

screen

@armanio123
Copy link
Contributor Author

This is for fixing it during typing.

Before this fix:
before

After this fix:
after

Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@armanio123 armanio123 merged commit b5d882e into microsoft:master May 22, 2018
@mhegazy
Copy link
Contributor

mhegazy commented May 22, 2018

@armanio123 please port to release-2.9

@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants