🤖 User test baselines have changed #24198
Conversation
| @@ -43,8 +43,8 @@ node_modules/async/auto.js(159,18): error TS2695: Left side of comma operator is | |||
| node_modules/async/auto.js(159,50): error TS2695: Left side of comma operator is unused and has no side effects. | |||
| node_modules/async/autoInject.js(44,17): error TS2695: Left side of comma operator is unused and has no side effects. | |||
| node_modules/async/autoInject.js(134,6): error TS2695: Left side of comma operator is unused and has no side effects. | |||
| node_modules/async/autoInject.js(136,25): error TS2722: Cannot invoke an object which is possibly 'undefined'. | |||
There was a problem hiding this comment.
@weswigham these are all ordering issues, i thought your last change should address these..
There was a problem hiding this comment.
Didn't accept any baselines, was waiting for the bot to open a PR.
| @@ -5,7 +5,7 @@ index.js(138,21): error TS2532: Object is possibly 'undefined'. | |||
| src/cli/util.js(262,64): error TS2339: Property 'length' does not exist on type 'Ignore'. | |||
| src/cli/util.js(335,52): error TS2339: Property 'length' does not exist on type 'Ignore'. | |||
| src/cli/util.js(396,46): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | |||
| src/cli/util.js(403,39): error TS2339: Property 'grey' does not exist on type 'typeof import("E:/Github/TypeScript/node_modules/chalk/types/index")'. | |||
| src/cli/util.js(403,39): error TS2339: Property 'grey' does not exist on type 'typeof import("/opt/vsts/work/1/s/node_modules/chalk/types/index")'. | |||
There was a problem hiding this comment.
why is that absolute path?
There was a problem hiding this comment.
It's outside of the test directory and I made a mistake and assumed the cloned dir would be named TypeScript for other paths.
| @@ -0,0 +1,8 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| index.ts(1,28): error TS7016: Could not find a declaration file for module 'leveldown'. '/opt/vsts/work/1/s/tests/cases/user/leveldown/node_modules/leveldown/leveldown.js' implicitly has an 'any' type. | |||
There was a problem hiding this comment.
we should make this also report a relative name.
| @@ -0,0 +1,8 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| index.ts(1,28): error TS7016: Could not find a declaration file for module 'leveldown'. '/opt/vsts/work/1/s/tests/cases/user/leveldown/node_modules/leveldown/leveldown.js' implicitly has an 'any' type. | |||
There was a problem hiding this comment.
@sandersn did leveldown stop shipping types?
There was a problem hiding this comment.
Sounds like they are either switching to a separate repo (?) or else DefinitelyTyped: Level/leveldown#474
Edit: the current expectation is that your tsconfig will have types: ['level-typings'] but it sounds like they want to move this to @types/leveldown later.
|
Thanks bot; I've stolen your work and removed leveldown at #24227. I'm sure one day you'll get a merge 😉 |
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @mhegazy