Support signature help for partially-filled-in type arguments f<
#24138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
signatureHelpTypeArguments
branch
2 times, most recently
from
ad5441c to
9e74450
Compare
ghost
force-pushed
the
signatureHelpTypeArguments
branch
from
9e74450 to
c6cc8e7
Compare
sheetalkamat
requested changes
May 17, 2018
src/services/signatureHelp.ts
Outdated
| argumentsSpan: createTextSpan(attributeSpanStart, attributeSpanEnd - attributeSpanStart), | ||
| argumentIndex: 0, | ||
| argumentCount: 1 | ||
| }; | ||
| } | ||
|
|
||
| else if (isBinaryExpression(node.parent)) { |
There was a problem hiding this comment.
Can you please use isPossiblyTypeArgumentPosition instead?
| return undefined; | ||
| function getCandidateInfo(argumentInfo: ArgumentListInfo, checker: TypeChecker): { readonly candidates: ReadonlyArray<Signature>, readonly resolvedSignature: Signature } | undefined { | ||
| const { invocation } = argumentInfo; | ||
| if (invocation.kind === InvocationKind.Call) { |
There was a problem hiding this comment.
what about new expressions?
mjbvz
added a commit
to microsoft/vscode
that referenced
this pull request
May 22, 2018
|
I've added should be in the next insiders build |
sheetalkamat
approved these changes
May 23, 2018
ghost
force-pushed
the
signatureHelpTypeArguments
branch
from
b089cdb to
208076a
Compare
|
Don't know why VSTS isn't running tests. |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports signature help at
f<,f<T,f<T, U,, etc.Required some reworking since we no longer always have a
CallLikeExpressionhandy. We now no longer expose as much tocompletions.ts, making it call a special functiongetArgumentInfoForCompletions.