In new Promise
, default T to void
#23538
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the following is a compile error:
Because the constructor provides:
Since there's no way to infer
T
, it is{}
by default.Before #22772,
value
was always optional and there was no problem. But now many DefinitelyTyped tests are failing because they rely on being able to callresolve()
without providing an explicit type argument.I think
void
makes a more sensible default than{}
, which would fix the issue, but would technically be a breaking change becausenew Promise(resolve => { resolve({}); })
will now be broken.(CC @falsandtru)