Do not watch child directories of the sym link folders #22976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Mar 29, 2018
| @@ -392,9 +393,12 @@ namespace ts { | |||
| function watchChildDirectories(parentDir: string, existingChildWatches: ChildWatches, callback: DirectoryWatcherCallback): ChildWatches { | |||
| let newChildWatches: DirectoryWatcher[] | undefined; | |||
| enumerateInsertsAndDeletes<string, DirectoryWatcher>( | |||
| host.directoryExists(parentDir) ? host.getAccessileSortedChildDirectories(parentDir) : emptyArray, | |||
There was a problem hiding this comment.
i am guessing this shoudl be getAccessibleSortedChildDirectories
mhegazy
reviewed
Mar 29, 2018
src/compiler/sys.ts
Outdated
| host.directoryExists(parentDir) ? host.getAccessileSortedChildDirectories(parentDir) : emptyArray, | ||
| host.directoryExists(parentDir) ? mapDefined(host.getAccessileSortedChildDirectories(parentDir), child => { | ||
| const childFullName = getNormalizedAbsolutePath(child, parentDir); | ||
| return host.filePathComparer(childFullName, host.realpath(childFullName)) === Comparison.EqualTo ? childFullName : undefined; |
There was a problem hiding this comment.
can you add a comment on why we are filtering here.
mhegazy
approved these changes
Mar 29, 2018
|
Please port to release-2.8 as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22668 and maintains same feature set as fs.watch on windows when node supports it.