Skip to content

Simplify implementation of firstOrUndefined and lastOrUndefined #22572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 14, 2018

@sandersn mentioned this having a confusing implementation. As of this PR elementAt will only be used in one place -- now we use non-negative indexing everywhere else.

@ghost ghost requested review from sandersn and rbuckton March 14, 2018 17:08
@ghost ghost mentioned this pull request Mar 14, 2018
@ghost ghost merged commit 1736741 into master Mar 14, 2018
@ghost ghost deleted the lastOrUndefined branch March 14, 2018 19:40
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant