Skip to content

Pass stack trace limit to parallel workers, and always convert to number #22527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2018
Merged

Pass stack trace limit to parallel workers, and always convert to number #22527

merged 2 commits into from
Mar 14, 2018

Conversation

sandersn
Copy link
Member

Now you can pass the stackTraceLimit=4 without breaking anything, with both runtests and runtests-parallel

sandersn added 2 commits March 13, 2018 16:28
@sandersn
Pass stackTraceLimit to parallel workers
c9084c5 
Specifying it breaks some output, both in parallel and normal runners.
I'll look at that in another commit, probably another PR, depending on
how simple the problem is.
@sandersn
Always convert stackTraceLimit to a number
7fc0194 
Sometimes it's not a number, even though the type claims it is.
@sandersn sandersn requested a review from weswigham March 14, 2018 00:00
@sandersn sandersn merged commit 24fdb52 into master Mar 14, 2018
@sandersn sandersn deleted the pass-stackTraceLimit-to-parallel-workers branch March 14, 2018 14:05
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @weswigham