getJSDocParameterTags: Always return defined result #22523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Mar 13, 2018
src/compiler/checker.ts
Outdated
| } | ||
| return isInJavaScriptFile(node) && ( | ||
| node.type && node.type.kind === SyntaxKind.JSDocOptionalType | ||
| || some(getJSDocParameterTags(node), paramTag => paramTag.isBracketed || !!paramTag.typeExpression && paramTag.typeExpression.type.kind === SyntaxKind.JSDocOptionalType)); |
There was a problem hiding this comment.
can you figure out a way to make this line shorter? probably just breaking it after the first argument to some would work.
ghost
force-pushed
the
getJSDocParameterTags_defined
branch
from
fc941a1 to
5ea6c28
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no semantic difference between
[]andundefinedhere, so always returning[]cleans up a lot ofundefinedchecks.(Will conflict with #22514, I'll rebase)