Skip to content

Port generated lib files #22381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2018
Merged

Port generated lib files #22381

merged 2 commits into from
Mar 7, 2018

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Mar 7, 2018

@mhegazy mhegazy added the Breaking Change Would introduce errors in existing code label Mar 7, 2018
@mhegazy mhegazy added this to the TypeScript 2.8 milestone Mar 7, 2018
@mhegazy mhegazy mentioned this pull request Mar 7, 2018
Closed
@mhegazy mhegazy mentioned this pull request Mar 7, 2018
Closed
@mhegazy mhegazy merged commit 963acb3 into master Mar 7, 2018
@mhegazy mhegazy deleted the portGeneratedLibFiles3-7 branch March 7, 2018 22:41
@mhegazy mhegazy mentioned this pull request Mar 9, 2018
Merged
@styfle
Copy link
Contributor

styfle commented Apr 1, 2018

@mhegazy This change broke my code because selectionStart: number is now selectionStart: number | null on interface HTMLInputElement. The same for selectionEnd.

However I don't believe this is correct because MDN doesn't mention that the property is nullable.

When would this return null?

@mhegazy
Copy link
Contributor Author

mhegazy commented Apr 2, 2018

Please file a new ticket and will get it fixed.

@styfle styfle mentioned this pull request Apr 2, 2018
Closed
@styfle
Copy link
Contributor

styfle commented Apr 2, 2018

@mhegazy Thanks, I created #23094

@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking Change Would introduce errors in existing code
Projects
None yet
Milestone
TypeScript 2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@mhegazy @styfle