-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Enable '--strictNullChecks' #22088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable '--strictNullChecks' #22088
Changes from all commits
8deee11
1484c0a
cf4f760
e31b4e9
28991e1
f600af7
3622f1c
5632d41
376adac
7b21e6e
36a28f1
f7f10d6
df0b2a3
555e1ae
40cd3ce
7a8dc71
cc0b4ca
a108007
99a8e68
df4b16d
cc3e642
e39a1b2
38b3cc2
f216df4
62bded5
d3dac33
da8639f
d83ba16
1116c90
34906ef
3b721e7
6556a30
edb3234
8521b9d
d3871cf
e2fd71b
174a011
3895991
76dcc5c
5d34edc
676dc93
1fe25f1
9b0fad1
5c59f4c
f803f19
383cd70
6f77c34
6152c9b
8cda69c
b0bcef5
4d63f37
e4d8b76
34a0611
0900823
c10ace5
b98cbbb
660477f
ddffe1f
ced45f4
95fdfaf
0b53a42
bd0b455
971fa9a
94c416d
54a37db
4c8ec96
3f066aa
9867f7d
4dc981f
faf868f
3c0dc90
828d18b
334b6d8
11acd0b
1f63084
8d562da
7c30658
e958ece
cd5c852
03d284d
32d0421
0a0653e
301f8c2
c59c7ec
e770b1d
8b7a620
86d3334
9d2914a
1347f67
366cc3e
5cedbc8
1f69c48
596c644
321f1c2
42f7daa
99f142b
a369a80
afea2dc
08d061d
30ad569
133d006
95b3b7a
00dab27
2b1f78e
c0672e2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ export class Rule extends Lint.Rules.AbstractRule { | |
function walk(ctx: Lint.WalkContext<void>): void { | ||
ts.forEachChild(ctx.sourceFile, recur); | ||
function recur(node: ts.Node): void { | ||
if (node.kind === ts.SyntaxKind.InKeyword && node.parent.kind === ts.SyntaxKind.BinaryExpression) { | ||
if (node.kind === ts.SyntaxKind.InKeyword && node.parent!.kind === ts.SyntaxKind.BinaryExpression) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. parent is not optional, why is this required? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This uses our published |
||
ctx.addFailureAtNode(node, Rule.FAILURE_STRING); | ||
} | ||
} | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just
--strict
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and same in gulpfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and same in tsconfig.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--strictPropertyInitialization
gives a ton of errors, as does--strictFunctionTypes
.