isValidMethodAccess: Instantiate signature this type if necessary #21722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Feb 7, 2018
src/compiler/checker.ts
Outdated
| @@ -11191,7 +11194,7 @@ namespace ts { | |||
| } | |||
|
|
|||
| function createInferenceContext(signature: Signature, flags: InferenceFlags, compareTypes?: TypeComparer, baseInferences?: InferenceInfo[]): InferenceContext { | |||
| const inferences = baseInferences ? map(baseInferences, cloneInferenceInfo) : map(signature.typeParameters, createInferenceInfo); | |||
| const inferences = baseInferences ? baseInferences.map(cloneInferenceInfo) : signature.typeParameters.map(createInferenceInfo); | |||
There was a problem hiding this comment.
Looks like this function should never be called if signature.typeParameters is undefined, since we expect inferences to always be defined elsewhere.
ghost
mentioned this pull request
ghost
force-pushed
the
completionsMethodWithThisParameter_instantiate
branch
from
952e29b to
bc54e99
Compare
sandersn
approved these changes
Mar 6, 2018
| return signatureThisType; | ||
| } | ||
| const context = createInferenceContext(sig.typeParameters, sig, InferenceFlags.None); | ||
| inferTypes(context.inferences, actualThisType, signatureThisType); |
There was a problem hiding this comment.
It's a little weird to do limited inference here, but maybe it makes sense because this is called solely for completions? The inference and instantiation will happen later, and lead to an error, in normal compilation.
There was a problem hiding this comment.
Since the call expression doesn't actually exist (we're just considering adding the completion, all that exists so far is obj.), this won't have a corresponding normal compilation.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21711