Skip to content

Fix harness getDirectores implementation to not include directory as prefix #21633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Feb 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 5, 2018

Fixes #21100 (comment)

We already had fourslash tests for getting directories in path completions. But, the harness implementation of getDirectories differed from the original one, as it returned directories with the prefix present.
Now directory completions with paths should for real in addition to in fourslash tests. (See the linked comment for repro instructions.)

@ghost ghost requested review from rbuckton and sheetalkamat February 5, 2018 18:53
@rbuckton
Copy link
Contributor

rbuckton commented Feb 5, 2018

I am completely replacing the implementation of getDirectories in #20763, so we'll need to coordinate this change.

@ghost
Copy link
Author

ghost commented Feb 5, 2018

I went with standardizing returning "foo" instead of "/directory/path/foo" because all getDirectories implementations but the one in harnessLanguageService seemed to be doing that already. So long as your PR also keeps that behavior in all getDirectories implementations I don't think there will be any conflict.

Copy link
Contributor

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update my PR after this is in.

@ghost ghost merged commit 1784e51 into master Feb 5, 2018
@ghost ghost deleted the getDirectories branch February 5, 2018 19:11
ghost pushed a commit that referenced this pull request Feb 6, 2018
ghost pushed a commit that referenced this pull request Feb 6, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant