Skip to content

Accept new user test baselines #21576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2018
Merged

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Feb 2, 2018

The chrome devtools baselines have some more specific boolean types in their errors, similar to our RWC tests, and formik removed one error from their example (likely from the change I proposed) - formik is still unlikely to compile clean until #21383 is merged.

@weswigham weswigham requested review from sandersn and mhegazy February 2, 2018 18:39
@weswigham weswigham merged commit b3cc65d into microsoft:master Feb 3, 2018
@weswigham weswigham deleted the accept-user-bl branch February 3, 2018 02:21
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants