Collect import helper needs during module info gathering #21567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Feb 2, 2018
| // @filename: refs.d.ts | ||
| declare module "path"; | ||
| // @filename: file.ts | ||
| import path from "path"; |
There was a problem hiding this comment.
add another test for import *
mhegazy
approved these changes
Feb 2, 2018
|
Please port to release-2.7 as well. |
rbuckton
approved these changes
Feb 2, 2018
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Feb 2, 2018
…1567) * Collect import helper needs during module info gathering * Add tests for other forms that trigger import helpers
weswigham
added a commit
that referenced
this pull request
Feb 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to how similar info is gathered to enable the
exportStarhelper in a similar fashion.Fixes #21560