Skip to content

Minor cleanup in getDynamicIndentation #21240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jan 17, 2018
Merged

Minor cleanup in getDynamicIndentation #21240

1 commit merged into from
Jan 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2018

  • getEffectiveDelta doesn't need a delta parameter, since that's in scope. Renaming this to getDelta since that's the property name.
  • Break shouldAddDelta out of getIndentationForToken to clarify that there are only two possible return values. Moved the decorator check to the back (OK because all of the above code would return false;, so when we test this doesn't affect the result).

@ghost ghost requested a review from aozgaa January 17, 2018 21:10
@ghost ghost merged commit 1dcc83e into master Jan 17, 2018
@ghost ghost deleted the getDynamicIndentation branch January 17, 2018 22:29
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant