smartIndenter: Don't indent after control-flow ending statements like break;
#20016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Nov 14, 2017
| export function shouldIndentChildNode(parent: TextRangeWithKind, child?: TextRangeWithKind): boolean { | ||
| return nodeContentIsAlwaysIndented(parent.kind) || nodeWillIndentChild(parent, child, /*indentByDefault*/ false); | ||
| function isControlFlowEndingStatement(kind: SyntaxKind) { | ||
| switch (kind) { |
There was a problem hiding this comment.
should we also check that it is the last statement of the block?
e.g.:
switch(x) {
case 1:
if (cond)
break;
|
}There was a problem hiding this comment.
We always dedent after a statement in a brace-less if anyway.
mhegazy
approved these changes
Nov 14, 2017
added 2 commits
November 15, 2017 09:21
ghost
merged commit 
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19973