Allow reserved words in type queries. #199
Conversation
|
Ignore the Travis-CI failure, I'm still sorting out issues with it, it should be disabled now. |
| var entity: EntityName = parseIdentifier(); | ||
| while (parseOptional(SyntaxKind.DotToken)) { | ||
| var node = <QualifiedName>createNode(SyntaxKind.QualifiedName, entity.pos); | ||
| node.left = entity; | ||
| node.right = parseIdentifier(); | ||
| node.right = allowReservedWords ? parseIdentifierName() : parseIdentifier(); |
There was a problem hiding this comment.
on the right of a dot, shouldn't we always allow reservedWords?
There was a problem hiding this comment.
Ah, n/m. i see the subtlety here. Could you doc the reasoning behind this. Specifically, that normally an Entity name could never have keywords in it, since it can only refer to module names on the left, and an identifier on the right (and module names can only be identifiers). however, for typeof, you need to allow identifier names on the right.
There was a problem hiding this comment.
Right, it parses an EntityName by default but when you specify true for the optional parameter it parses a TypeQueryExpression. I can add a comment to that effect.
Making allowReservedWords parameter of parseEntityName non-optional.
Allow reserved words in type queries.
Fixes #181.