Skip to content

【BugFix/lib.d.ts】fix constructor in URLSearchParams #19021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kgtkr
Copy link

@kgtkr kgtkr commented Oct 8, 2017

Fixes #15338

@msftclas
Copy link

msftclas commented Oct 8, 2017

CLA assistant check
All CLA requirements met.

@ikatyang
Copy link
Contributor

ikatyang commented Oct 9, 2017

from https://github.com/Microsoft/TypeScript/tree/master/src/lib#readme:

Generated files

Any files ending in .generated.d.ts aren't mean to be edited by hand.
If you need to make changes to such files, make a change to the input files for our library generator.

@mhegazy
Copy link
Contributor

mhegazy commented Oct 9, 2017

Thanks for your PR. As @ikatyang mentioned, these files are not manually edited, they are auto-generated from a script in . You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TSJS-lib-generator.

Changes should be done in https://github.com/Microsoft/TSJS-lib-generator instead.

Please find more information at: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy mhegazy closed this Oct 9, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants