add types for escape and unescape methods #18813 #19015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
although the issue is marked working as expected, it is important to mention that most major browsers maintain support for escape and unescape, and some javascript codebases moving to typescript may have escape and unescape in them. They are valid JavaScript, and thus they should be included in the global definition.
|
|
|
Thanks for the contribution. but the omission of these functions from the library is intentional. please see #18813 (comment) |
|
@mhegazy - In the current ES Draft spec, as well as in MDN I see no reference to escape / unescape being deprecated anymore. What is your reference for it still being deprecated? |
|
u are right. there does not seem to be a deprecation notice any longer. |
|
@wbhob mind refreshing the PR and addressing the failing tests? |
mhegazy
reviewed
Nov 9, 2017
| @@ -1,14 +1,14 @@ | |||
| /*! ***************************************************************************** | |||
There was a problem hiding this comment.
I think that was automatically generated
|
I'll look into fixing those tests soon |
|
🎉 Yay! Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the issue is marked working as expected, it is important to mention that most major browsers maintain support for escape and unescape, and some javascript codebases moving to typescript may have escape and unescape in them. They are valid JavaScript, and thus they should be included in the global definition.
Fixes #18813