Skip to content

Keep comments in production tsserverlibrary builds #18913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weswigham
Copy link
Member

Our tsserver library build differed from our services build in that it didn't explicitly include comments in the release mode build. This fixes that, and should fix the nightly.

@weswigham weswigham requested review from rbuckton and mhegazy October 3, 2017 18:03
@weswigham weswigham merged commit 5c7a3d0 into microsoft:master Oct 3, 2017
@weswigham weswigham deleted the retain-comments-in-prod-tsserverlibrary branch October 3, 2017 18:18
@weswigham
Copy link
Member Author

Fixed #18906

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants