navigation tree / bar: Set span of anonymous function to span of VariableDeclaration containing it #18575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
…ableDeclaration containing it
armanio123
reviewed
Sep 19, 2017
src/services/navigationBar.ts
Outdated
| else if (decl.initializer && isFunctionOrClassExpression(decl.initializer)) { | ||
| // For `const x = function() {}`, just use the function node, not the const. | ||
| addChildrenRecursively(decl.initializer); | ||
| else if (initializer && (isArrowFunction(initializer) || isFunctionExpression(initializer) || isClassExpression(initializer))) { |
There was a problem hiding this comment.
I suggest not removing the function because it makes easier to understand the code. But do use the helpers functions inside.
armanio123
approved these changes
Sep 19, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14251