Actually be able to run RWC tests in parallel #18453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our RWC harness was running all tests on all threads under
runtests-parallel, which was not particularly helpful. With this, each thread only runs the work it has been partitioned.This can let you get RWC results faster; however it's still a bit suboptimal, as certain RWC tests take up more than 1/8th of the test CPU cycles on their own; so the balance is a little off and some threads finish a few minutes before the slowest one. In any case, this is a nice improvement for now; until we get around to making them take work from a shared queue rather than a preallocated partition.