Continue parsing unterminated regexes #18294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we incorrectly recognise slash token as the start of an unterminated string literal, and this allows those cases to produce a correct parse. It would be better for the parser to correctly parse slash token instead, because this way adds bogus parse errors for unterminated regex literals.
|
A fourslash test failed. I'll update it. |
This was referenced Sep 7, 2017
|
#18417 is a better fix than this, and this PR should be closed if it is merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we incorrectly recognise slash token as the start of an unterminated regex literal, and this allows those cases to produce a correct parse. It would be better for the parser to correctly parse slash tokens instead, because this way adds bogus parse errors for unterminated regex literals.
This was introduced back in 2014 in 886feda and 7dd30d3, having to with simplifying how regexes are incrementally parsed. Looking at that change may show how to correctly classify slash tokens.
Fixes #18158
Fixes #18306
Edit: unterminated regex literal, not string literal.