Skip to content

Cleanup getDiagnosticsForProject #18151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 14, 2017
Merged

Cleanup getDiagnosticsForProject #18151

1 commit merged into from
Sep 14, 2017

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2017

  • Instead of testing whether ".d.ts" is contained anywhere within a filename, just check the end.
  • Move fileNamesInProject.length test up, since sorting won't change that.
  • Use array spread to avoid multiple concats.

@ghost ghost force-pushed the getDiagnosticsForProject branch from e548741 to a4d537a Compare August 30, 2017 16:09
@ghost ghost requested a review from sheetalkamat August 30, 2017 16:09
@ghost ghost merged commit 0de1b23 into master Sep 14, 2017
@ghost ghost deleted the getDiagnosticsForProject branch September 14, 2017 19:38
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sheetalkamat sheetalkamat Awaiting requested review from sheetalkamat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhegazy @msftclas