Array arguments to concat should be ReadonlyArrays
#17806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mhegazy
approved these changes
Aug 16, 2017
|
In inference, overloads are processed pairwise (if I recall correctly) so you need the same number of overloads for Array and ReadonlyArray to get correct inferences from each other. |
|
In other words, if Array has two overloads, then ReadonlyArray needs two as well. Whether both are needed is a separate question, but I think if you look through the issue and PR history for Array.concat, you'll find that both are needed. |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17076
@sandersn You added the second overload in #10374, is there a reason we need two?