Emit names for methods #17673
Closed
Emit names for methods #17673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
added
Awaiting More Feedback
weswigham
force-pushed
the
emit-names-for-methods
branch
from
8d79fe1 to
7468855
Compare
weswigham
force-pushed
the
emit-names-for-methods
branch
from
7468855 to
0df7d2c
Compare
|
Same comment as i did in #16001. the fix does not seem as simple as adding a name. closing for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5611
@rbuckton mentioned that we might not actually want this, so this will likely be discussed at a design meeting in the future.
This implementation is largely what was proposed in this comment, and applied to both class methods and object literal methods.
@DanielRosenwasser @mhegazy You should probably be aware of this.