Skip to content

Clean up creation of 'args' in client.ts #17009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jul 7, 2017
Merged

Clean up creation of 'args' in client.ts #17009

1 commit merged into from
Jul 7, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 7, 2017

@ghost ghost requested a review from weswigham July 7, 2017 14:29
weswigham
weswigham approved these changes Jul 7, 2017
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This consolidates a lot of similar logic, so seems like a nice improvement. 👍

@ghost ghost merged commit d4c11bf into master Jul 7, 2017
@ghost ghost deleted the args branch July 7, 2017 15:10
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswigham @msftclas