Enable debug info when running tests #16310
Conversation
|
Is there a difference between running and debugging tests here? I expect we only want this information when debugging unless it's printed to the output files. |
| Object.defineProperties(objectAllocator.getTypeConstructor().prototype, { | ||
| "__debugFlags": { get(this: Type) { return formatTypeFlags(this.flags); } }, | ||
| "__debugObjectFlags": { get(this: Type) { return this.flags & TypeFlags.Object ? formatObjectFlags((<ObjectType>this).objectFlags) : ""; } }, | ||
| "__debugTypeToString": { value(this: Type) { return this.checker.typeToString(this); } }, |
There was a problem hiding this comment.
should not this be a getter too?
There was a problem hiding this comment.
No. typeToString performs type checking, which could result in caching resolutions/types/etc. This can be problematic when you are in the middle of debugging a resolution.
Its available as a method as there are cases where you would like to get a view of type while debugging and typeToString is not available as it is not in the environment record of the closure.
There was a problem hiding this comment.
i just wounder how slow it would be to do this on every type when you are debugging.
There was a problem hiding this comment.
The performance impact so far has been fairly small, as far as my own experience has been, as it only matters when the debugger is paused as that is the only time the watch window performs expression evaluation.
In #16120 I added some additional members to
Node,Symbol, andTypethat are only available when debugging the compiler. These provide some at-a-glance information about runtime enum values. This change makes them available when debugging tests as well.