[Master] Take into account optional property in parameter #16070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
suggested changes
May 25, 2017
src/compiler/binder.ts
Outdated
| @@ -2178,7 +2178,11 @@ namespace ts { | |||
| case SyntaxKind.JSDocRecordMember: | |||
| return bindPropertyWorker(node as JSDocRecordMember); | |||
| case SyntaxKind.JSDocPropertyTag: | |||
| return declareSymbolAndAddToSymbolTable(node as JSDocPropertyTag, SymbolFlags.Property, SymbolFlags.PropertyExcludes); | |||
| let optionalType = 0; | |||
| if ((node as JSDocPropertyTag).typeExpression.type.kind === SyntaxKind.JSDocOptionalType) { | |||
There was a problem hiding this comment.
typeExpression could be undefined.
There was a problem hiding this comment.
consider inlinng this as:
function bindJSDocPropertyTag(node: JSDocPropertyTag) {
return declareSymbolAndAddToSymbolTable(node, node.typeExpression && node.typeExpression.type.kind === SyntaxKind.JSDocOptionalType? SymbolFlags.Property | SymbolFalgs.Optionl : SymbolFlags.Property, SymbolFlags.PropertyExcludes);
}
added 2 commits
May 25, 2017 19:49
mhegazy
approved these changes
May 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15916