Fix jsdoc typedef symbol scope + avoid bind twice if the type has a namespace prefix #14014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Feb 14, 2017
src/compiler/binder.ts
Outdated
|
|
||
| function bindJSDocTypedefTag(node: JSDocTypedefTag) { | ||
| forEachChild(node, n => { | ||
| // if the node has a fullName "A.B.C", that means symbol "C" was already bond |
vladima
reviewed
Feb 16, 2017
src/compiler/binder.ts
Outdated
| // if the node has a fullName "A.B.C", that means symbol "C" was already bound | ||
| // when we visit "fullName"; so when we visit the name "C" as the next child of | ||
| // the jsDocTypedefTag, we should skip binding it. | ||
| if (n === node.name && node.fullName.kind !== SyntaxKind.Identifier) { |
There was a problem hiding this comment.
this bit implies that fullName can be undefined. Is this case handled?
There was a problem hiding this comment.
That should be an parsing error. If parsed correctly, fullName should always has value. Will update
There was a problem hiding this comment.
Aha I forgot the following case ...
/* @typedef { string | number } */
var NumberLike;
It can be undefined after all.
There was a problem hiding this comment.
can you add this as a testcase?
|
@vladima further comments? |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12233